Attention is currently required from: daniel, jolly, pespin.
View Change
1 comment:
Patchset:
Patch Set #7:
The memory leak does happen, if all of my patches in gerrit (libosmo-netif) are applied. […]
I think the question daniel is racing:In the old code (pre 7e6d2e0f99ff095f4714f03b1ed991d6c9cb9c61) you could probably call osmo_stream_cli_open() successively twice or more times, and only the first time a new osmo_io_fd would be setup/allocated. Now, we don't have that guard anymore, and it means that multiple successive calls (whether legal or not) would allocate multiple iofd and leak them.
To view, visit change 35979. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932
Gerrit-Change-Number: 35979
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Mar 2024 08:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas@eversberg.eu>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>
Gerrit-MessageType: comment