Attention is currently required from: fixeria, laforge, pespin.

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #3, Line 862: LOGP(DLPFCP, LOGL_NOTICE, "cfg: pfcp netinst %s %s\n", access_or_core, *str);

    Ack

    it is very useful if osmo-upf posts what network resources it is using in the log at startup.
    for example, sometimes i don't remember the VTY port, or want to verify what interface is used; i always go read the startup logs. This is configuring network interfaces to be used for GTP, so I think it is profound enough to post this in the log.

• File src/osmo-hnbgw/ps_rab_fsm.c:

  • Patch Set #3, Line 202: #define set_netinst(NETINST_MEMBER, STRING) do { \

    imho another example of something which need not be a define macro, and which would definetly be bet […]

    main reason for macro is that it works for both

        struct osmo_pfcp_ie_pdi.network_inst
        struct osmo_pfcp_ie_pdi.network_inst_present

    and

        struct osmo_pfcp_ie_forw_params.network_inst
        struct osmo_pfcp_ie_forw_params.network_inst_present

    The NETINST_MEMBER##_present concatenation is only possible by macro.

    it's just private to a .c file, so I like to have a bit of syntactic sugar with my code dedup.

To view, visit change 35645. To unsubscribe, or for help writing mail filters, visit settings.