Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.

View Change

1 comment:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #10, Line 1132: msgLen = read(mDataSockets[chan], buffer, sizeof(buffer));

    Could you please clarify if I understood you correctly? […]

    I don't have a 100% specific implementation at hand, since I'm still not seeing afacit how are you passing the buffers in the emscripten case.

    But my general point is yes, something like what you mention. I don't see why you forcibly need some intermediate buffers, I'd say the methods/APIs/classes can be adapted to be more modular to fullfill your requirements.

    
    That needs some more extra work that what you presented so far in order to be merged though, not just a bunch of ifdefs or some weird code paths/functions where you may either pull a buffer or pass it, etc.

    In summary, if you plan to exchange TRXC and TRXD with something else, then provide proper abstraction for it and present it.

To view, visit change 42411. To unsubscribe, or for help writing mail filters, visit settings.