Attention is currently required from: fixeria, pespin.
2 comments:
Patchset:
This is something that needs to be done carefully: you're adding a new field, but the PCUIF version […]
I have had a look at this. I think CHECK_IF_MSG_SIZE may tolerate this. It checks if the length of the date it received is smaller than the indication. In case more data is received, the check won't be set off.
This would mean newer osmo-bts/osmo-bsc would definetly work with older osmo-pcu versions, but the other way around there may be problems (I didn't count out the bytes)
So yes, I also think this means that we must increment the PCUIF version again. But before we do this we should drop the backward compatibility clutter in osmo-pcu and the TTCN3 tests to have a clean path.
File include/osmocom/pcu/pcuif_proto.h:
Patch Set #1, Line 70: #define PCU_IF_BTS_MODEL_UNSPEC 0x00
can we please have an enum?
I have opted against an enum since the other fields also do not use enums (see the defines above). I think an enum will look a bit out of place there.
What do you think? Shall I still migrate this to an enum?
To view, visit change 34647. To unsubscribe, or for help writing mail filters, visit settings.