Attention is currently required from: laforge, pespin, lynxis lazus.

Patch set 3:Code-Review -1

View Change

5 comments:

• File include/osmocom/hlr/gsup_server.h:

  • Patch Set #3, Line 71: osmo_gsup_create_insert_subscriber_data_msg

    this looks like a public API function of libosmo-gsup to me? In that case, we cannot simply break A […]

    Looks like it is, although only osmo-hlr seem to be using it. I did `./gits do grep osmo_gsup_create_insert_subscriber_data_msg` and could not find any other osmo-projects using it. But still, I would avoid breaking public API even if none of our projects are using it.

• File src/gsup_server.c:

  • Patch Set #3, Line 455: void *talloc_ctx)

    because it's not guaranteed that gsup is a talloc allocated buffed.

    Agreeing with @lynxis here.

• File src/hlr.c:

  • Patch Set #3, Line 133: sub_upd_ctx

    Let's better use `OTC_SELECT` and avoid `goto`s. If you don't like this idea, then maybe allocate this context outside of the loop and then free? Is there really a need to have a dedicated context for each iteration?

• File src/lu_fsm.c:

  • Patch Set #3, Line 249: lu_isr_ctx

    I suggest simply using `OTC_SELECT` here.

  • Patch Set #3, Line 251: return

    memleak!

To view, visit change 32511. To unsubscribe, or for help writing mail filters, visit settings.