Attention is currently required from: canghaiwuhen, laforge, pespin.
5 comments:
Patchset:
Please also adjust the commit message text to have a brief distinct subject and more detailed descri […]
Done
Commit Message:
Patch Set #5, Line 7: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets.
Missing first line with acceptable length. You are writing the whole description in the first line.
Done
File src/sgsn/gprs_gmm.c:
Patch Set #5, Line 1339: } else {
All changes in this file are totally unrelated to those of QoS. […]
Done
Patch Set #5, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state.
These lines are too long, split them.
Done
Patch Set #5, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi);
Line too long.
Done
To view, visit change 42050. To unsubscribe, or for help writing mail filters, visit settings.