Attention is currently required from: arehbein, laforge, pespin.

View Change

1 comment:

• File src/core/gsmtap_util.c:

  • Patch Set #5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);

    simply never read from that fd and just keep it open there so no ICMP errors are sent

    Yeah, one option is to keep it like it was not using osmo_io (so that the read doesn't allocate).

    I was wondering what happens if you open the socket and simply never read from it since we don't care about the data anyway.

    I don't think it's worth the effort here because we might need to decrease the kernel receive buffer and even then the kernel could send ICMP errors.

    So I'd suggest to keep the source_add_sink code as it was before (using osmo_fd with the read callback).

To view, visit change 34743. To unsubscribe, or for help writing mail filters, visit settings.