Attention is currently required from: pespin.

View Change

1 comment:

• File src/core/socket.c:

  • Patch Set #1, Line 603: if (bind(sfd, &local->u.sa, osmo_sockaddr_size(local)) == -1) {

    Context: this patch is […]

    Correction to my previous comment in this thread, which is wrong. The union's sockaddr_storage member does represent an AF_UNIX address: sockaddr_un is 106 bytes on Darwin against a 128 byte union, and libosmocore relies on that in osmo_sock_get_name_buf(), which reads the AF_UNIX case back through a struct sockaddr_un *. So AF_UNIX can reach this code path. That comment was an unsent draft published by accident together with my cover message. Please take the cover message on patch set 1 as my answer instead.

To view, visit change 43574. To unsubscribe, or for help writing mail filters, visit settings.