Attention is currently required from: neels, osmith.

View Change

1 comment:

• File include/osmocom/core/utils.h:

  • Patch Set #1, Line 329: } while (0)

    What is the advantage of having these long macros instead of turning them into (probably more readab […]

    I agree. I don't really see anything in the macro at first glance which couldn't be achieved in a function, or at least an inline function. The use of macros should be constrained to situations where we really need to solve something that's not super trivial and not possible in an (if needed, inline) funtion.

To view, visit change 35207. To unsubscribe, or for help writing mail filters, visit settings.