Attention is currently required from: Hoernchen.
View Change
1 comment:
Patchset:
Patch Set #9:
Pong. […]
so that IMHO means there's basically two ways forward: You replace all instances of the magic 100 with a self-explanatory #define, or you wait until somebdoy else will do that for you to move the patch ahead. If that #define will get put next to the log levels (below LOGL_FATAL) it is less likely that somebody else will come up with some other magic high log-level that is above 100 and breaks your logic.
To view, visit change 30633. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d
Gerrit-Change-Number: 30633
Gerrit-PatchSet: 11
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Comment-Date: Wed, 10 May 2023 12:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment