Attention is currently required from: jolly, pespin.

View Change

11 comments:

• File library/s1ap/S1AP_Templates.ttcn:

  • Patch Set #1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation,

    Are you sure this ID is correct?

    It may look confusing, but yes, it's correct.
    See 3GPP TS 36.413, section 8.4.1 "Handover Preparation".

  • Patch Set #1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation,

    Are you sure this ID is correct?

    It may look confusing, but yes, it's correct.
    See 3GPP TS 36.413, section 8.4.1 "Handover Preparation".

  • Patch Set #1, Line 2370: }

    (FYI, see in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40985/2/library/ranap/RANAP_Templates. […]

    Optional IEs can be added later whenever they're needed.
    For testing the S1 HANDOVER procedures, it's enough to have mandatory IEs only.

  • Patch Set #1, Line 2374: ts_E_RABSubjecttoDataForwardingList(template (value) E_RABDataForwardingItem it) := {

    IMHO it's better to have a template for E_RABSubjecttoDataForwardingItem, and then simply do "{ ts_E […]

    `E-RABSubjecttoDataForwardingItem` does not exist in the ASN.1 definition, so it's not possible to define templates for a single list item. This is how it's defined:

    ```
    E-RABSubjecttoDataForwardingList ::= E-RAB-IE-ContainerList { {E-RABDataForwardingItemIEs} }
    ```

    Same applies to the `E_RABModifyListBearerModConf` templates above.

  • Patch Set #1, Line 2423: successfulOutcome := {

    Are you sure the HandoverCmd is a succesfulOutcome and not an InitialMessage? […]

    Yes, because this PDU is sent in response to the `HANDOVER REQUIRED`.

    • `HANDOVER REQUIRED` - `initiatingMessage`,
    • `HANDOVER COMMAND` - `successfulOutcome`.

    See 3GPP TS 36.413, section 8.4.1 "Handover Preparation".

  • Patch Set #1, Line 2424: procedureCode := S1AP_Constants.id_HandoverPreparation,

    Are you sure this ID is correct?

    See above (yes).

  • Patch Set #1, Line 2450: }

    We definitely want `E-RABs to Release List` IE (optional) here.
    Not a merge blocker, can be added later in a separate patch.

  • Patch Set #1, Line 2462: procedureCode := S1AP_Constants.id_HandoverPreparation,

    same comments as per ts_S1AP_HandoverCmd apply here too.

    See above.

  • Patch Set #1, Line 2560: procedureCode := S1AP_Constants.id_HandoverResourceAllocation,

    are you sure this ID is correct?

    Yes. See 3GPP TS 36.413, section 8.4.2 "Handover Resource Allocation".

  • Patch Set #1, Line 2638: *,

    I see no optional IEs between the `E-RABs To Be Setup List` and `Source to Target
    Transparent Container`, so a wildcard is not needed here.

  • Patch Set #1, Line 2732: }, {

    Likewise, would be nice to have optional `E-RABs Failed to Setup List` IE here.
    Not a merge blocker, can be added later in a separate patch.

To view, visit change 41008. To unsubscribe, or for help writing mail filters, visit settings.