Attention is currently required from: osmith, pespin, lynxis lazus.

Patch set 2:Code-Review -1

View Change

1 comment:

• File daemon/tun_device.c:

  • Patch Set #2, Line 204: pthread_cleanup_pop(tun_device_pthread_cleanup_routine);

    man pthread_cleanup_pop reads:

    """The pthread_cleanup_pop() function removes the routine at the top of the stack of clean-up handlers, and optionally executes it if execute is nonzero."""

    So it will always pop the last cleanup handler, the only choice you have is if you want it to be executed or not.

    I also don't see how you can reach this code (at the moment), there's no break in the while loop.

To view, visit change 27739. To unsubscribe, or for help writing mail filters, visit settings.