Attention is currently required from: laforge, pespin.

1 comment:

Patchset:
- Patch Set #2:
  I'm not sure either. […]
  i think it is fine to leave it inline, because we don't always inlcude jhash.h -- only in the .c file that actually does the hashing:
  our linuxlist.h and msgb.h are all over the place, so that code gets recompiled over and over. They are very complex, so we always need all of the .h file.
  in comparison, jhash.h is only needed in the .c file that implements the my_foo_hash(cont struct my_foo *val) function. IOW it is easy to contain the recompilations, not like in linuxlist and msgb with an entire API that is "always" needed.
  agree?

To view, visit change 36913. To unsubscribe, or for help writing mail filters, visit settings.