Attention is currently required from: Andrei G.

Patch set 1:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    IMHO this makes the code much less readable. How about this approach:

    Define a `SED_I` variable that is set to `sed -i` by default. Then check if running on mac os, and if that is the case, set the variable to `sed -i ''`. Use `$(SED_I)` instead of directly calling `sed -i` everywhere.

    After reading through https://osxhub.com/sed-command-mac/#inplace that should probably do it, but as I don't use mac os I have of course not tested it.

To view, visit change 43588. To unsubscribe, or for help writing mail filters, visit settings.