Attention is currently required from: arehbein, fixeria, daniel.

Patch set 11:Code-Review +1

View Change

2 comments:

• File src/gsm/ipa.c:

  • Patch Set #8, Line 728: * -EIO, if the header declares a payload too large */

    hmm weird, I remember reading somewhere that Osmocom comments do *not* put the comment end marker on […]

    There's no specific stone-written rule anywhere I'm aware of, and both are accepted. In function documentation though, where lots of comments is written in a formatted way, I believe it's clearer leaving the */ at the end. Up to you.

  • Patch Set #8, Line 729: int ipa_segmentation_cb(struct msgb *msg)

    So what's wrong with the Doxygen style comment? It doesn't contradict the description you quote.

    I was just sharing it here to make it easy for others (and myself) while reviewing, since this function didn't provide how it expected to do the segmentation.

To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.