Attention is currently required from: neels, pespin.

View Change

1 comment:

• File src/libosmo-pfcp/Makefile.am:

  • Patch Set #1, Line 68: gen__pfcp_ies_auto_LDFLAGS

    I presume LDFLAGS and LDADD are the same thing, one replaces the earlier LDFLAGS and the other doesn't replace but just append?

    No, these are different things. The `LDFLAGS` is for stuff like: `-Wl,--wrap=foo`, `-version-info`, `-no-undefined`, `-no-install`, etc. The `LDADD` is for libraries. As I said above, the key difference is that the `LDFLAGS` appears first in the linker's command line, while the `LDADD` appears last.

    Since AM_LDFLAGS include LIBOSMOCORE_LIBS, then the local lib is appended by LDADD after libosmocore, which then fails. By using LDFLAGS, not LDADD, the order is being fixed, because no other libs are listed before libosmo-gtlv.a.

    `AM_LDFLAGS` shall never contain `*_LIBS`, since it ends up first in the linker's command line. The actual fix is to not have `*_LIBS` in `AM_LDFLAGS`.

To view, visit change 31741. To unsubscribe, or for help writing mail filters, visit settings.