Attention is currently required from: pespin.

View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 8:

    I'd mention here that GSM_IMSI_LENGTH was 16, and OSMO_IMSI_BUF_SIZE is 17:

    ```
    include/osmocom/gsm/protocol/gsm_23_003.h:#define GSM23003_IMSI_MAX_DIGITS 15
    include/osmocom/gsm/protocol/gsm_23_003.h:#define OSMO_IMSI_BUF_SIZE (GSM23003_IMSI_MAX_DIGITS+2)
    ```

• File src/host/layer23/src/common/subscriber.c:

  • Patch Set #3, Line 232: strlen(imsi) - 1 > OSMO_IMSI_BUF_SIZE - 1

    is this still correct?

To view, visit change 32436. To unsubscribe, or for help writing mail filters, visit settings.