fixeria submitted this change.

View Change



3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved
esim/saip: raise an exception properly

Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b
---
M pySim/esim/saip/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py
index bdbbccf..9fa1d28 100644
--- a/pySim/esim/saip/__init__.py
+++ b/pySim/esim/saip/__init__.py
@@ -441,7 +441,7 @@
elif k == 'fillFileContent':
stream.write(v)
else:
- return ValueError("Unknown key '%s' in tuple list" % k)
+ raise ValueError("Unknown key '%s' in tuple list" % k)
return stream.getvalue()

def file_content_to_tuples(self, optimize:bool = False) -> List[Tuple]:

To view, visit change 42389. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b
Gerrit-Change-Number: 42389
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>