Attention is currently required from: arehbein, fixeria, pespin.

View Change

1 comment:

• File src/osmo-bsc/meas_feed.c:

  • Patch Set #5, Line 148:

    &(struct osmo_io_ops) {
    					.read_cb = meas_feed_noop_cb,
    					.write_cb = meas_feed_noop_cb,
    					.segmentation_cb = NULL,
    				      }, NULL);
    

    Can we have this struct defined outside of the function call? […]

    The read callback (if set) also needs to free the msgb, otherwise we leak memory.
    Since I11ce072510b591f7881d09888524426579bd0169 is merged you could also leave the read_cb NULL.

To view, visit change 34526. To unsubscribe, or for help writing mail filters, visit settings.