Attention is currently required from: osmith, laforge.

View Change

1 comment:

• File library/RSL_Types.ttcn:

  • Patch Set #2, Line 389: RSL_SpeechAlgoDataRate

    I am currently looking at 3GPP TS 48.058 section 9.3.6, and I see the following:

      If octet 4 indicates speech, then octet 6 is coded as follows:
      0000 0001      - GSM speech coding algorithm version 1
      ...
      0000 1101      - GSM speech coding algorithm version 6
      All other values are reserved.

    Then below I see:

      If octet 4 indicates data, then octet 6 is coded as follows:

    So the encoding of octet 6 depends on the value of octet 4.
    The octet 6 itself is defined as follows:

      Speech coding algor./data rate + transp ind

    AFAIU, the '/' means either speech or data.

    I don't think mixing up all encoding variants in one enumerated type is a good idea. I would rather have several enums grouped into a union.

To view, visit change 31556. To unsubscribe, or for help writing mail filters, visit settings.