Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-bts-trx/sched_lchan_tchh.c:

  • Patch Set #1, Line 85: int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1;

    Then having a static inline function fn_is_facch which does "!sched_tchh_ul_facch_map[bi->fn % 26]" […]

    I am not a big fan of this kind of functions, sorry. This statement:

      sched_tchh_ul_facch_map[bi->fn % 26]

    is self-explaining, IMO. The negation is required because gsm0503_tch_hr_decode() involves double-negation: it would try to decode the buffer as FACCH/H if its argument 'odd' is false.

To view, visit change 27722. To unsubscribe, or for help writing mail filters, visit settings.