Attention is currently required from: osmith, laforge, pespin.

View Change

1 comment:

• File src/host/layer23/src/modem/grr.c:

  • Patch Set #3, Line 278: if ((dm_or_tbf & (1 << 1)) == 0) {

    You can use "bool is_ul_ass = (dm_or_tbf & (1 << 1))", or rather in line 277 simply write "Check UL […]

    I don't see how this improves readability, sorry. A boolean flag would improve a bit, but it's redundant to add a bool for one-time use in the if statement next line. The comment suggestions... there is already a comment stating that we check Request Reference IE if this is an Uplink TBF assignment.

To view, visit change 33414. To unsubscribe, or for help writing mail filters, visit settings.