laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved
tlv: Make NotImplementedError more verbose

This helps to understand immediately _what_ is not implemented for which
type.

Change-Id: I017eb4828e9deee80338024c41c93c0f78db3f3b
---
M pySim/tlv.py
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pySim/tlv.py b/pySim/tlv.py
index 4de5046..5acc781 100644
--- a/pySim/tlv.py
+++ b/pySim/tlv.py
@@ -100,7 +100,7 @@

# not an abstractmethod, as it is only required if no _construct exists
def _to_bytes(self):
- raise NotImplementedError
+ raise NotImplementedError('%s._to_bytes' % type(self).__name__)

def from_bytes(self, do: bytes):
"""Convert from binary bytes to internal representation. Store the decoded result
@@ -118,7 +118,7 @@

# not an abstractmethod, as it is only required if no _construct exists
def _from_bytes(self, do: bytes):
- raise NotImplementedError
+ raise NotImplementedError('%s._from_bytes' % type(self).__name__)


class IE(Transcodable, metaclass=TlvMeta):

1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 28681. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I017eb4828e9deee80338024c41c93c0f78db3f3b
Gerrit-Change-Number: 28681
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged