Attention is currently required from: neels.

View Change

2 comments:

• Patchset:

  • Patch Set #5:

    I think this should work, but make sure that the plaintext output is not fed into the logic that checks the header.

• File pySim/esim/http_json_api.py:

  • Patch Set #5, Line 431: if 'header' in output:

    I think you should draw this header check into the conditional branch because when we decode a plaintext and it has the string "header" somewhere in it, we might generate unexpected exceptions here.

To view, visit change 42155. To unsubscribe, or for help writing mail filters, visit settings.