Attention is currently required from: daniel, laforge, neels.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    I am wondering if there's another alternative that we can do this without introducing the clumsy *2( […]

    @laforge@osmocom.org you mean keeping the segmentation_cb(1) and adding "cli/srv" pointer inside msgb->dst or cb[]?

    I'd prefer having a proper param as in cb2, because:

    • osmo_io anyway already has such a cb
    • we are already using msg->cb[] to store some information in sctp sockets iirc.
    • It becomes easier for users to understand quickly how to implement stuff when looking at the API instead of having to read docuemntaion details regarding the object being available in that field of msg.

    IMHO the initial segmentation_cb without a data param both in osmo_io and osmo_stream was a bad choice, and I really think it makes sense to deprecate it and get rid of it at some point.

To view, visit change 39316. To unsubscribe, or for help writing mail filters, visit settings.