Attention is currently required from: pespin.

View Change

1 comment:

• File src/sctp_proxy.erl:

  • Patch Set #2, Line 197: handle_pdu(Data) when is_binary(Data) ->

    isn't the when_is_binary() and the spec declaring the param to be binary() actually the same? I thin […]

    The spec is for Dialyzer, it does not affect the program logic IIUC. The `is_binary()` guard ensures that this function variant is only executed when the given argument is of a binary type. The idea is to ensure that we never pass `s1ap_proxy:handle_pdu/1` anything else than a binary, and thus never blame it a bug that is actually ours (this module's own).

To view, visit change 37122. To unsubscribe, or for help writing mail filters, visit settings.