Attention is currently required from: fixeria, laforge, pespin.
4 comments:
Commit Message:
Patch Set #1, Line 15: be discarded, for the benefit of the new one.
we do the same in osmo-pcu with tbfs btw (ms_merge_and_clear_ms()).
interesting, which way around is that? do we also drop the old one there?
Patchset:
are we sure this code path only gets triggered after authentication [assuming authentication is enab […]
I thought about that, too. The situation is:
This happens before Auth:
If authentication is switched off, then this doesn't hold of course, but nothing else does either.
File src/libmsc/paging.c:
Patch Set #1, Line 147: vlr_subscr_put(discarding_vsub, VSUB_USE_PAGING);
Ah indeed it missed that one.
yes, i wanted to keep that close together, but the use count put should happen in the end, while the if() should happen in the start... i'll drop a comment there
File src/libvlr/vlr.c:
Patch Set #1, Line 597: struct vlr_instance *vlr = exists->vlr;
I'd rpobably move all this code to its own function "vsub_join()" or alike.
ack
(the paging_request_join() function was supposed to be that own function, but then this code here grew and grew with more aspects to be taken care of...)
To view, visit change 36452. To unsubscribe, or for help writing mail filters, visit settings.