Attention is currently required from: laforge, dexter.
5 comments:
Commit Message:
Patch Set #4, Line 10: add a floored and an euclidian modulo function to be more complete.
please name the place where / the reason why you would like to use these ideally with change-id reference to another patch
File include/osmocom/core/utils.h:
would be very helpful to include a brief explanation, sort of like "A modulo where the result always has the sign of the divisor"
you neet to put braces around every single occurence of these parameters like
(x) + (y)
It is also a good idea to not use names commonly used in C code, so rather X and Y.
"A modulo where the result is always positive" or something
Patch Set #4, Line 195: y > 0 ? x % y + y : x % y - y
please put braces around this section.
also braces around each (x) and (y)
also X and Y
To view, visit change 30933. To unsubscribe, or for help writing mail filters, visit settings.