View Change

3 comments:

• File include/osmocom/core/logging.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 447: struct log_target *log_target_create_web();

    Bad function definition - struct log_target *log_target_create_web() should probably be struct log_target *log_target_create_web(void)

• File src/core/logging_web.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 84: struct log_target *log_target_create_web()

    Bad function definition - struct log_target *log_target_create_web() should probably be struct log_target *log_target_create_web(void)

• File src/vty/telnet_interface_dummy.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 74: }

    void function return statements are not generally useful

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.