laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
rspro_client_fsm: Fix integer overflow calculating re-establishment delay

Fixes: CID#307493: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
Change-Id: Ib1cca5ac0d27807936a52e0c013f0442350ecc00
---
M src/rspro_client_fsm.c
1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index 321dcf2..72176ab 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -238,7 +238,7 @@
}

/* determine if we need to delay reestablishment */
- const int64_t need_ms = k_reestablish_delay_s[srvc->reestablish_delay_idx] * 1000;
+ const int64_t need_ms = (int64_t) k_reestablish_delay_s[srvc->reestablish_delay_idx] * 1000;
int64_t delay_ms = need_ms - since_last_ms;

if (delay_ms > 0) {

To view, visit change 33777. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ib1cca5ac0d27807936a52e0c013f0442350ecc00
Gerrit-Change-Number: 33777
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged