Attention is currently required from: osmith.

4 comments:

File contrib/sima-response-tool.py:
- Patch Set #1, Line 57:
```
                     8 : 'template-not-supported',
                     9 : 'feature-not-supported',
```
```suggestion […]
Thanks. (I have tried to get those constants from asn1tools using introspection, but I couldn't figure this out. Unlike the ServicesList (see saip-tool.py), this is just a plain integer type.)
- Patch Set #1, Line 74: propritary
```suggestion […]
Done
- Patch Set #1, Line 77: return "%d (unknown, propritary?)" % (status, status)
  contrib/sima-response-tool. […]
  Done
- Patch Set #1, Line 93: if euicc_response_decoded.get('profileInstallationAborted', False) is None:
  Is comparing against `is None` correct here? I wonder if it should be compared against `is True` as […]
  I agree, this is confusing. The type is defined as profileInstallationAborted NULL OPTIONAL. This means, that when it is present it has the value None, so None effectively means True then. False is when profileInstallationAborted is not present at all. Unfortunately the confusion already starts with the ASN.1 definition. I have added a comment to make it more clear.

To view, visit change 40936. To unsubscribe, or for help writing mail filters, visit settings.