fixeria submitted this change.

View Change

s1ap_proxy: fix discarded result of handle_ies/3 in HO REQ ACK handler

The call processing the optional E-RABFailedToSetupListHOReqAck IE did
not pattern-match its return value, causing any errors returned by
handle_ies/3 to be silently swallowed.  Bind the result to {_, S2}
to make the intent explicit.

Change-Id: I1c8feeb63fe23876ae443784980e9dc22a450c54
---
M src/s1ap_proxy.erl
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl
index a29a817..ef7665e 100644
--- a/src/s1ap_proxy.erl
+++ b/src/s1ap_proxy.erl
@@ -604,8 +604,8 @@
     end,
     %% handle the (optional) list of failed E-RABs
     %% no #proxy_state modification is expected here
-    handle_ies(?'id-E-RABFailedToSetupListHOReqAck',
-               C0#'HandoverRequestAcknowledge'.protocolIEs, S2),
+    {_, S2} = handle_ies(?'id-E-RABFailedToSetupListHOReqAck',
+                         C0#'HandoverRequestAcknowledge'.protocolIEs, S2),
     {Result, S2};
 
 

To view, visit change 42294. To unsubscribe, or for help writing mail filters, visit settings.