Attention is currently required from: fixeria, pespin.

View Change

2 comments:

• File include/l1ctl_proto.h:

  • Patch Set #5, Line 217: uint8_t tch_flags;

    > Do we have some versioning of the proto? […]

    I decided to move the tch_flags to the end of the structures. I could add the L1CTL_TCH_FLAG_RXONLY to the audio_mode, but it is not audio related. It turns the transmitter off for both TCH and SACCH frames.

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #5, Line 3042: LOGP(DRR, LOGL_INFO, " Channel type %d, subch %d, ts %d, mode %d, audio-mode %d, flags %d, cipher %d\n",

    you most probably want to print flags with 0x02%x here

    Done

To view, visit change 34479. To unsubscribe, or for help writing mail filters, visit settings.