Attention is currently required from: pespin.

View Change

3 comments:

• File src/libsmpputil/smpp_msc.c:

  • Patch Set #49, Line 847: if (!g_smsc->link) {

    why is this check added now?

    Hmm.. yepp, it can be dropped.

• File src/libsmpputil/smpp_smsc.c:

  • Patch Set #49, Line 166: acl->esme = NULL;

    Nice bug here setting to null before calling put on it. […]

    Ack

  • Patch Set #49, Line 760: uint32_t smpp_size = esme->read_msg ? esme->read_msg->cb[0] : 0;

    you are casting unsigned long to "uint32_t". […]

    I think it's better to use the type which matches exactly the size from SMPP spec - 4 bytes.

To view, visit change 28849. To unsubscribe, or for help writing mail filters, visit settings.