Attention is currently required from: osmith, pespin.

View Change

1 comment:

• File src/gprs/gprs_llc_parse.c:

  • Patch Set #1, Line 138: ghp->data = (uint8_t *)&ctrl[3];

    Then you are breaking the const constraints here, so you shouldn't be doing this ;)

    Yes, but why doing this is wrong? gprs_llc_hdr_parse() itself does not modify *llc_hdr, so it's const here. The caller does modify the payload, so it's not const in struct gprs_llc_hdr_parsed. I see no problems here.

To view, visit change 29279. To unsubscribe, or for help writing mail filters, visit settings.