Attention is currently required from: osmith.
View Change
1 comment:
File src/mtp3_hmdt.c:
Patch Set #2, Line 180: prim->u.transfer = xua->mtp;
was this removed on purpose?
It's moved inside m3ua_to_xfer_ind() just above, where it should be.
The previous behavior was:
- Put data payload header (m3ua_dh) decoded into prim->u.transfer (line 161)
- Copy xua->mtp into prim->u.transfer.
As you can see, the second operation actually made the first one a no-op.
So I'm basically getting rid of the first operation with the change, moving the second one to the function m3ua_to_xfer_ind().
To view, visit change 43844. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic7982f38babcc11d740745a04b155de856517504
Gerrit-Change-Number: 43844
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Oct 2026 09:22:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>