Attention is currently required from: lynxis lazus.

2 comments:

File src/aaa_diameter_swx_tests.erl:

Patch Set #1, Line 51:

    AMar = {'MAR',
        ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"],
        1, % auth session state
        undefined, undefined, undefined, % origin host, origin realm, dest realm
        "262426399104394",
        {'Vendor-Specific-Application-Id',10415,[16777265],[]},
        {'SIP-Auth-Data-Item',[],["EAP-AKA"],[],[],[],[],[],[],<<"">>,[],[],[],[]},

There exists a record for this called `#'MAR'` in `include/diameter_3gpp_ts29_273_swx.hrl`:

```suggestion
    SessionId = ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"],
    VAID = #'Vendor-Specific-Application-Id'{'Vendor-Id' = 10415,
                                             'Auth-Application-Id' = [16777265]},
    AMar = #'MAR'{'Session-Id' = SessionId,
                  'Auth-Session-State' = 1,
                  'User-Name' = "262426399104394",
                  'Vendor-Specific-Application-Id' = VAID,
                  'SIP-Auth-Data-Item' =,
                  'SIP-Number-Auth-Items' = 1,
                  'RAT-Type' = 1},
```

This would have been a lot more readable.

Patch Set #1, Line 90: = Encoded#diameter_packet.bin.
You should be using `?assertEqual` and `?assertMatch` if you want to match something.

To view, visit change 41072. To unsubscribe, or for help writing mail filters, visit settings.