Attention is currently required from: arehbein, pespin.

View Change

2 comments:

• File include/osmocom/netif/stream.h:

  • Patch Set #9, Line 63:

    #define osmo_stream_srv_unset_segmentation_cb(STRUCT_OSMO_STREAM_SRV_PTR)\
    	osmo_stream_srv_set_segmentation_cb((STRUCT_OSMO_STREAM_SRV_PTR), NULL)
    

    If we want this, I would put it in a function and export it. This is not a performance critical path where we need to in-line or work with #defines.

    Having a function call in the source code be transparently changed into another function call can make debugging, tracing, profiling, ... harder - with no apparent benefit (in this case, at least).

• File include/osmocom/netif/stream.h:

  • Patch Set #1, Line 25: osmo_stream_proto

    I have for now put `osmo_stream_trx_mode` instead; the name should be more general than just referri […]

    TRX unfortunately has a very specific meaning in the context of GSM, so it is at least as bad as "protocol" in terms of a socket API :( We'll have to find something better.

To view, visit change 33197. To unsubscribe, or for help writing mail filters, visit settings.