Attention is currently required from: pespin.

View Change

1 comment:

• File src/host/trxcon/src/trxcon.c:

  • Patch Set #1, Line 270: /* Reparent trxcon_inst from ctx to trxcon->fi */

    Here again, reparenting makes everything more convoluted and difficult to follow imho, and must be u […]

    We're dealing with a chicken-egg problem here. trxcon_inst is allocated first because a) it holds a pointer to an FSM instance, so we can do trxcon->fi = osmo_fsm_inst_alloc(...) directly; b) we pass a pointer to trxcon_inst when calling osmo_fsm_inst_alloc(), so it becomes fi->priv. To me using talloc_reparent() does not really look that critical.

To view, visit change 28862. To unsubscribe, or for help writing mail filters, visit settings.