dexter has uploaded this change for review.

View Change

esipa_asn1_handler_utils: rename EsipaReq to Debuginfo

The parameter EsipaReq only exists because we pass it as
Debuginfo to mnesia_db_work:finish. Let's rename it to
"Debuginfo" in esipa_asn1_handler_utils as well to make
clear what the purpose of this parameter is.

Change-Id: I8115d382172989b9ef7ae7f97ce39520e3e2dd16
Related: SYS#8100
---
M src/esipa_asn1_handler_utils.erl
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/49/42949/1

diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl
index 171f78b..1b8039f 100644
--- a/src/esipa_asn1_handler_utils.erl
+++ b/src/esipa_asn1_handler_utils.erl
@@ -24,7 +24,7 @@
             none
     end.
 
-process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, EimTransactionId) ->
+process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo, EimTransactionId) ->
     WorkBind = fun(Map) ->
         case maps:is_key(eimTransactionId, Map) of
             true ->
@@ -83,18 +83,18 @@
                 [{[{euiccPackageErrorCode, undefinedError}]}]
         end,
 
-    mnesia_db_work:finish(Pid, Outcome, EsipaReq).
+    mnesia_db_work:finish(Pid, Outcome, Debuginfo).
 
 % Handle an EuiccPackageResult, this includes everything from the handling of the work items in mnesia_db, down to
 % signature checks and the generation of an appropriate outcome for the REST API.
-handle_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq) ->
+handle_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo) ->
     EimTransactionId = eimTransactionId_from_euiccPackageResult(EuiccPackageResult),
     {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId),
     case crypto_utils:verify_euiccPackageResultSigned(EuiccPackageResult, EidValue) of
         ok ->
-            process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, EimTransactionId);
+            process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo, EimTransactionId);
         _ ->
             mnesia_db_work:finish(
-                Pid, [{[{procedureError, euiccSignatureInvalid}]}], EsipaReq
+                Pid, [{[{procedureError, euiccSignatureInvalid}]}], Debuginfo
             )
     end.

To view, visit change 42949. To unsubscribe, or for help writing mail filters, visit settings.