Attention is currently required from: pespin, fixeria.

View Change

2 comments:

• File src/osmo-bsc/bts.c:

  • Patch Set #1, Line 693: !osmo_bts_has_feature(&bts->features, BTS_FEAT_GPRS)) {

    note: model->features field can probably be turned const in the struct definition?

    This would need some refactoring, currently the various bts models make use of osmo_bts_set_feature(&model.features to set the model's features on initialization.

• File src/osmo-bsc/bts_trx_vty.c:

  • Patch Set #1, Line 346: return CMD_WARNING;

    Have you tested that starting osmo-bsc with 'model osmo-bts' and hopping parameters is still possibl […]

    Right, only the later patch https://gerrit.osmocom.org/c/osmo-bsc/+/27923/1 will make the features available in the bts model (so they are used before the bts reports its features). I've moved the change with "return CMD_WARNING" to that patch.

To view, visit change 27921. To unsubscribe, or for help writing mail filters, visit settings.