Attention is currently required from: laforge, pespin, fixeria.

View Change

1 comment:

• File include/osmocom/pfcp/pfcp_msg.h:

  • Patch Set #3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \

    Because in general it doesn't make sense to force the compiler to generate all that code duplicated […]

    on the contrary, if it is a function implemented in an .o,
    then the compiler has less optimization flexibility, IIUC.

    I've submitted a separate patch to change it to a va function,
    but I still disagree completely with this review,
    and I hate that patch, it makes everything worse.

    https://gerrit.osmocom.org/c/osmo-upf/+/28239

To view, visit change 27631. To unsubscribe, or for help writing mail filters, visit settings.