Attention is currently required from: pespin.

View Change

5 comments:

• File src/core/osmo_io.c:

  • Patch Set #4, Line 248: lh = iofd->tx_queue.msg_queue.prev;

    fyi we have llist_last(). […]

    I added the suggested llist_last_entry_or_null().

  • Patch Set #4, Line 451: if (rc < chunk)

    shouldn't this case be already handled in the if path in line 431?

    No, only if the write is incomplete, it is handled above.

  • Patch Set #4, Line 517: msghdr = iofd_txqueue_tail(iofd);

    why are you picking the tail here? Because the assumption is that the other before it are already fi […]

    Done

  • Patch Set #4, Line 531:

    you can simply do "idx = msghdr->msg_len - 1;" here, and simplify both branches above.

    Done

  • Patch Set #4, Line 539: rc = iofd_txqueue_enqueue(iofd, msghdr);

    are you submitting to io_uring queue inside here? Because then it looks like yoy may be modifying st […]

    If io_uring processes a msghdr, it has been removed from the queue before, so everything within the queue is not yet handled.

To view, visit change 40493. To unsubscribe, or for help writing mail filters, visit settings.