Attention is currently required from: daniel, laforge, neels, pespin.
Patch set 7:Code-Review +1
3 comments:
File src/libosmo-mgcp/mgcp_msg.c:
(is this function 1:1 unchanged? if the function had not moved, it would be trivially visible from t […]
in patchset 7, the endpoint name was added again to the log message
Patch Set #4, Line 210: goto mgcp_header_done;
non-functional cosmetic issue
resolving (let's get this big, almost 1 month patch out of the queue!)
Patch Set #4, Line 257: LOGP(DLMGCP, LOGL_NOTICE, "wrong MGCP option format: '%s'\n", line);
I've looked at https://gerrit.osmocom.org/c/osmo-mgw/+/39352, see my comment there.
What i don't want to see is that the parsing code does a lot of context-less logging of errors, and the user needs to guess from adjacent logging where the error originated from.
In the patch here, we now have one log message without the endp name (and there was another one in in parse_x_osmo_ign(), which has been fixed in patch version 7). This log message gets removed, and replaced with one that has the endp name in follow-up patch https://gerrit.osmocom.org/c/osmo-mgw/+/39352.
There is a separate open discussion about less logging context in osmux_init(), but Pau said he'll address that in follow-up patches too. In my opinion it is not worth blocking this almost 1 month old patch for this.
So it looks like we can resolve at least the discussion here.
To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.