View Change

5 comments:

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #7, Line 362: switch (((uint8_t *)msgb_l2(oph->msg))[1]) {

    hmm. […]

    Done

• File src/osmo-hnbgw/hnbgw_rua.c:

  • Patch Set #7, Line 273: case RANAP_ProcedureCode_id_RAB_Assignment:

    likewise the same here.

    Done

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #1, Line 451: g_hnb_gw->config.mgcp_client = talloc_zero(tall_hnb_ctx, struct mgcp_client_conf);

    This doesn't look like the proper place to do this. Please move this to the g_hnb_gw alloc function.

    Done

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #1, Line 84: /* We have to store the RANAP RAB AssignmentRequest message, since we can not take ownership of the osmo prim

    why can't you take ownsership? is it freed by the callback caller? If not, talloc_steal, if yes, msg […]

    It is freed by the code that calls mgw_fsm_alloc_and_handle_rab_ass_req() from hnbgw_cn.c. See also sccp_sap_up() It is built that way. We could try to change it though its only 4 functions that would have to be changed so that we can take ownership of the msg buffer.

  • Patch Set #1, Line 420: .in_event_mask = S(MGW_EV_MGCP_OK) | S(MGW_EV_MGCP_FAIL),

    I find it much more clear having one per line, but OK.

    If you give me an example from somewhere in the osmocom codebase I can replicate the coding style.

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.