Attention is currently required from: jolly, lynxis lazus.

View Change

2 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 262: Display availability status of all BTS

    `online` in the command name suggests that the command is supposed to show only those BTS instances, which are online. However, it's actually more like `brief`.

  • Patch Set #1, Line 268: for (bts_nr = 0; bts_nr < net->num_bts; bts_nr++)

    Not a performance critical path, but I would still suggest doing this:

    ```
    llist_for_each_entry(bts, &net->bts_list, list)
    ```

    instead. This is what `gsm_bts_num()` does internally. The problem with the current approach is that the higher `bts_nr` you pass it, the more iterations it takes to find the BTS instance.

To view, visit change 35567. To unsubscribe, or for help writing mail filters, visit settings.