Attention is currently required from: Hoernchen, daniel.

View Change

2 comments:

• File pySim/transport/__init__.py:

  • Patch Set #2, Line 72: def prepare_response(self, pcmd: ProactiveCommand, general_result: str = 'performed_successfully'):

    I think putting a spec ref (ETSI TS 102 223, section 6.8) would be very helpful here.

• File tests/unittests/test_transport.py:

  • Patch Set #2, Line 44: self.assertEqual(b2h(til[1].to_tlv()), '82028381')

    correct me if I am wrong, but as far as I understand we should also see encoded strings for CommandDetails and Result here as well. If so, we should assert them like in test_on_decoded_command.

    (They are mandatory IEs, so they should be there, right?)

To view, visit change 43543. To unsubscribe, or for help writing mail filters, visit settings.