Attention is currently required from: laforge, pespin, dexter.
View Change
1 comment:
Patchset:
Patch Set #2:
I agree with pau, I also thought that iterating over all connections of an endpoint would be the mos […]
My idea was to use pointers to increase performance. In most cases there is only one destination, so there is only one pointer to follow. Using a foreach-loop to check all connections for every packet produces much more overhead. OTOH, the code can be much more simplified it using a foreach-loop. The send/send_next pointers are obsolete then. What do you think?
To view, visit change 33548. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a
Gerrit-Change-Number: 33548
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jul 2023 09:40:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment