Attention is currently required from: falconia, fixeria, jolly, laforge.

View Change

2 comments:

• File include/osmocom/netif/twjit.h:

  • Patch Set #6, Line 50: struct osmo_twjit_config {

    The only struct that poses truly serious ABI issues is `osmo_twjit_config`. […]

    @falcon@freecalypso.org my preferred solution would be to actually remove the osmo_twjit_config from public space and instead have setter API for each param one wants to configure on the twjit. Only pass the really required ones during osmo_twjit_alloc(), and for the others set a sane default plus the mentioned setters to configure/tweak it afterwards.

    I know at first hand it looks like more work and more function calls to be made, but in the end this allows good maintainability, extensibility, etc.
    I'm saying this based on experience, for instance see the osmo_stream (stream.h) API which follows this approach and proved to cope well with extensions over time.

    Your proposal would work and I could accept it, but it I really dislike the idea of having to allocate an extra twjit_config struct.

    Let me know if my proposal is good for you.

• File src/twjit.c:

  • Patch Set #2, Line 504: rtph = osmo_rtp_get_hdr(msg);

    Can this issue be marked as resolved - is M bit handled to your satisfaction now?

    Done

To view, visit change 39280. To unsubscribe, or for help writing mail filters, visit settings.