Attention is currently required from: fixeria, pespin.
15 comments:
File src/core/osmo_io_uring.c:
Patch Set #10, Line 118: return
Looks like `msg` is leaked here. […]
I also combined submit_read() and submit_recvmsg() into one function since they are nearly identical
Patch Set #10, Line 126: Could not get io_uring_sqe
missing `\n`
Done
Patch Set #10, Line 130: // Prep msgb/iov
cosmetic: use the `/* ... […]
Done
Patch Set #10, Line 135: // NOTE: This only works if we have one read per fd
cosmetic: use the `/* ... […]
Done
Patch Set #10, Line 153: return
Again, looks like `msg` is leaked here.
Done
Patch Set #10, Line 165: Could not get io_uring_sqe
Again missing `\n`.
Done
Patch Set #10, Line 275: /* Fallthrough */
This comment is not really needed since there is no code preceding it.
Done
Patch Set #10, Line 295: io_uring_peek_cqe
Are you sure this is correct? […]
No, it looks wrong. Seems like I still got all cqes because peek would (eventually) return the same completion until its io_uring_cqe_seen()
Patch Set #10, Line 326: Could not get io_uring_sqe
missing '\n'
Done
if (!sqe)
OSMO_ASSERT(0);
`OSMO_ASSERT(sqe != NULL)`
Ack
Patch Set #10, Line 362: (void *)0x0
Why not `NULL`?
Done
if (!sqe)
OSMO_ASSERT(0);
`OSMO_ASSERT(sqe != NULL)`
Done
Patch Set #10, Line 397: return
`msg` is leaked here.
Done
Patch Set #10, Line 404: Could not get io_uring_sqe
missing `\n`
Done
ws
Done
To view, visit change 32536. To unsubscribe, or for help writing mail filters, visit settings.